[Python-checkins] r53489 - in python/trunk: Include/Python-ast.h Misc/NEWS Parser/asdl_c.py

[Thomas Wouters]

On 1/19/07, Jim Jewett <jimjjewett at gmail.com> wrote:
>
> How does this fix the issue?
>
> Adding the _Py_ names is a start, but I thought a fix would require
> removing the non-_Py_ names.  This code still #defines them, as an
> alias of the new name.


You only get the #define when you include Python-ast.h. You don't see those
names otherwise. That includefile isn't included in Python.h.

I would understand not removing the old names (or at least doing it
> only conditionally) in python2.5, but why keep them on the trunk?


It makes the code a lot more readable, IMHO. I don't know if that's why
Martin did it this way, though :)

-jJ
>
> On 1/19/07, martin.v.loewis <python-checkins at python.org> wrote:
> > Author: martin.v.loewis
> > Date: Fri Jan 19 07:42:22 2007
> > New Revision: 53489
> >
> > Modified:
> >    python/trunk/Include/Python-ast.h
> >    python/trunk/Misc/NEWS
> >    python/trunk/Parser/asdl_c.py
> > Log:
> > Prefix AST symbols with _Py_. Fixes #1637022.
> > Will backport.
>
>
> ==============================================================================
> > --- python/trunk/Include/Python-ast.h   (original)
> > +++ python/trunk/Include/Python-ast.h   Fri Jan 19 07:42:22 2007
>
> > -mod_ty Module(asdl_seq * body, PyArena *arena);
>
> ...
>
> > +#define Module(a0, a1) _Py_Module(a0, a1)
> > +mod_ty _Py_Module(asdl_seq * body, PyArena *arena);
> _______________________________________________
> Python-checkins mailing list
> Python-checkins at python.org
> http://mail.python.org/mailman/listinfo/python-checkins
>



-- 
Thomas Wouters <thomas at python.org>

Hi! I'm a .signature virus! copy me into your .signature file to help me
spread!
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.python.org/pipermail/python-checkins/attachments/20070119/7068367d/attachment.htm