[Python-checkins] r55106 - python/branches/py3k-struni/Lib/test/test_support.py

Guido van Rossum guido at python.org
Fri May 4 02:44:25 CEST 2007


I think this and similar places should use basestring.

On 5/3/07, walter.doerwald <python-checkins at python.org> wrote:
> Author: walter.doerwald
> Date: Thu May  3 23:11:35 2007
> New Revision: 55106
>
> Modified:
>    python/branches/py3k-struni/Lib/test/test_support.py
> Log:
> Temporary fix: Module names are still 8bit strings. This
> change allows test_support.run_unittest(__name__) to work
> again. However the proper fix would be module names that
> are real unicode strings.
>
>
> Modified: python/branches/py3k-struni/Lib/test/test_support.py
> ==============================================================================
> --- python/branches/py3k-struni/Lib/test/test_support.py        (original)
> +++ python/branches/py3k-struni/Lib/test/test_support.py        Thu May  3 23:11:35 2007
> @@ -534,7 +534,7 @@
>      valid_types = (unittest.TestSuite, unittest.TestCase)
>      suite = unittest.TestSuite()
>      for cls in classes:
> -        if isinstance(cls, str):
> +        if isinstance(cls, (str, str8)):
>              if cls in sys.modules:
>                  suite.addTest(unittest.findTestCases(sys.modules[cls]))
>              else:
> _______________________________________________
> Python-checkins mailing list
> Python-checkins at python.org
> http://mail.python.org/mailman/listinfo/python-checkins
>


-- 
--Guido van Rossum (home page: http://www.python.org/~guido/)


More information about the Python-checkins mailing list