[Python-checkins] r55452 - python/trunk/Modules/_bsddb.c

[Neal Norwitz]

On 5/19/07, "Martin v. Löwis" <martin at v.loewis.de> wrote:
> > Author: neal.norwitz
> > Date: Sat May 19 06:34:55 2007
> > New Revision: 55452
> >
> > Whoops, need to pay attention to those test failures.
> > Move the clear to *before* the first use, not after.
> >
> >
> > Modified: python/trunk/Modules/_bsddb.c
> > ==============================================================================
> > --- python/trunk/Modules/_bsddb.c     (original)
> > +++ python/trunk/Modules/_bsddb.c     Sat May 19 06:34:55 2007
> > @@ -1724,6 +1724,7 @@
> >      CHECK_DB_NOT_CLOSED(self);
> >      if (!make_key_dbt(self, keyobj, &key, NULL))
> >          return NULL;
> > +    CLEAR_DBT(data);
> >      if ( !make_dbt(dataobj, &data) ||
>
> Can you please explain what precise problem this fixes?
> make_dbt start with
>
>     CLEAR_DBT(*dbt);
>
> so data gets cleared anyway. If there was a bug somewhere,
> I cannot imagine this change making it go away.

Yeah, I botched this.  See the bug report for more details.  I think I
fixed it for real now.  The g4 buildbot will be good to watch since
that now has Berkeley DB 4.5 installed on it.

n