[Python-checkins] r62518 - in python/trunk: Modules/arraymodule.c Objects/bufferobject.c Objects/cellobject.c Objects/codeobject.c Objects/dictobject.c Objects/exceptions.c Objects/fileobject.c Objects/listobject.c Objects/methodobject.c Objects/

[Benjamin Peterson]

On Sat, Apr 26, 2008 at 10:55 PM, Nick Coghlan <ncoghlan at gmail.com> wrote:
> benjamin.peterson wrote:
>
> > Modified: python/trunk/Python/ceval.c
> >
> ==============================================================================
> > --- python/trunk/Python/ceval.c (original)
> > +++ python/trunk/Python/ceval.c Sun Apr 27 05:01:45 2008
> > @@ -3164,9 +3164,9 @@
> >          assert(PyExceptionClass_Check(type));
> >        if (Py_Py3kWarningFlag && PyClass_Check(type)) {
> > -               if (PyErr_Warn(PyExc_DeprecationWarning,
> > +               if (PyErr_WarnEx(PyExc_DeprecationWarning,
> >                               "exceptions must derive from BaseException "
> > -                              "in 3.x") == -1)
> > +                              "in 3.x", 1) == -1)
> >                        goto raise_error;
> >        }
> >
>
>  Should this be changed to use '< 0' for consistency with the other checks?

Yes. I changed a few others, but it seems I missed that one.



-- 
Cheers,
Benjamin Peterson