[Python-checkins] r60892 - in python/branches/release25-maint: Lib/test/test_struct.py Misc/NEWS

[Guido van Rossum]

Hm. I would have been happier with just disabling the test if
sys.maxsize > some value. Having a regression test for this crasher
has some value, even if the crasher is 32-bit specific.

On Feb 18, 2008 9:46 AM, martin.v.loewis <python-checkins at python.org> wrote:
> Author: martin.v.loewis
> Date: Mon Feb 18 18:46:27 2008
> New Revision: 60892
>
> Modified:
>    python/branches/release25-maint/Lib/test/test_struct.py
>    python/branches/release25-maint/Misc/NEWS
> Log:
> Bug #2137: Remove test_struct.test_crasher, which was meaningful
> only on 32-bit systems.
>
>
> Modified: python/branches/release25-maint/Lib/test/test_struct.py
> ==============================================================================
> --- python/branches/release25-maint/Lib/test/test_struct.py     (original)
> +++ python/branches/release25-maint/Lib/test/test_struct.py     Mon Feb 18 18:46:27 2008
> @@ -618,12 +618,8 @@
>      value, = struct.unpack('>I', data)
>      vereq(value, 0x12345678)
>
> -def test_crasher():
> -    assertRaises(MemoryError, struct.pack, "357913941c", "a")
> -
>  # Test methods to pack and unpack from buffers rather than strings.
>  test_unpack_from()
>  test_pack_into()
>  test_pack_into_fn()
>  test_unpack_with_buffer()
> -test_crasher()
>
> Modified: python/branches/release25-maint/Misc/NEWS
> ==============================================================================
> --- python/branches/release25-maint/Misc/NEWS   (original)
> +++ python/branches/release25-maint/Misc/NEWS   Mon Feb 18 18:46:27 2008
> @@ -15,6 +15,9 @@
>  - Fix deallocation of array objects when allocation ran out of memory.
>    Remove array test case that was incorrect on 64-bit systems.
>
> +- Bug #2137: Remove test_struct.test_crasher, which was meaningful
> +  only on 32-bit systems.
> +
>
>  What's New in Python 2.5.2c1?
>  =============================
> _______________________________________________
> Python-checkins mailing list
> Python-checkins at python.org
> http://mail.python.org/mailman/listinfo/python-checkins
>



-- 
--Guido van Rossum (home page: http://www.python.org/~guido/)