[Python-checkins] r61969 - in python/trunk: Include/bytes_methods.h Objects/longobject.c Objects/unicodeobject.c Python/mystrtoul.c

[Eric Smith]

neal.norwitz wrote:
> Author: neal.norwitz
> Date: Thu Mar 27 05:40:50 2008
> New Revision: 61969
> 
> Modified:
>    python/trunk/Include/bytes_methods.h
>    python/trunk/Objects/longobject.c
>    python/trunk/Objects/unicodeobject.c
>    python/trunk/Python/mystrtoul.c
> Log:
> Fix warnings about using char as an array subscript.  This is not portable
> since char is signed on some platforms and unsigned on others.

Is there any reason not to make Py_CHARMASK just do the cast to 
unsigned?  I see lots of other uses of Py_CHARMASK that potentially have 
this same problem.