[Python-checkins] r63159 - python/trunk/Lib/urllib.py

[Nick Coghlan]

ronald.oussoren wrote:
> Author: ronald.oussoren
> Date: Mon May 12 13:31:05 2008
> New Revision: 63159
> 
> Log:
> MacOSX: remove dependency on Carbon package for urllib
> 
> This patch removes the dependency on the Carbon package from urllib. 
> The mac-specific code for getting proxy configuration is now writting in
> Python using ctypes and uses the SystemConfiguration framework instead of
> InternetConfig. Also provides a mac-specific implementation of proxy_bypass.

There appear to be a lot of imports inside functions in this patch - 
what are the chances of any of this code being called from a thread 
spawned as side effect of an import, and hence deadlocking an application?

It may be better to pull the imports up to be module level code (but 
still guarded by the check for 'darwin' as the platform)

Cheers,
Nick.

-- 
Nick Coghlan   |   ncoghlan at gmail.com   |   Brisbane, Australia
---------------------------------------------------------------
             http://www.boredomandlaziness.org