[Python-checkins] r63081 - sandbox/trunk/2to3/lib2to3/fixes/fix_imports.py

Collin Winter collinw at gmail.com
Thu May 15 19:46:19 CEST 2008


On Sun, May 11, 2008 at 1:06 PM, alexandre.vassalotti
<python-checkins at python.org> wrote:
> Author: alexandre.vassalotti
> Date: Sun May 11 22:06:36 2008
> New Revision: 63081
>
> Log:
> Added import fixer for Queue rename.

You forgot a comma before 'Queue'. This indicates that you clearly
didn't run the tests when you made this change, nor for any of the
subsequent changes (if you had, it would have resulted in a
SyntaxError). Do not check in code you haven't tested. 2to3 has a
comprehensive test suite; use it.

> Modified:
>   sandbox/trunk/2to3/lib2to3/fixes/fix_imports.py
>
> Modified: sandbox/trunk/2to3/lib2to3/fixes/fix_imports.py
> ==============================================================================
> --- sandbox/trunk/2to3/lib2to3/fixes/fix_imports.py     (original)
> +++ sandbox/trunk/2to3/lib2to3/fixes/fix_imports.py     Sun May 11 22:06:36 2008
> @@ -22,6 +22,8 @@
>                                     'add_extension',
>                                     'remove_extension',
>                                     'clear_extension_cache'])
> +           'Queue': ('queue', ['Empty', 'Full', 'Queue',
> +                               'PriorityQueue', 'LifoQueue']),
>           }
>
>
> _______________________________________________
> Python-checkins mailing list
> Python-checkins at python.org
> http://mail.python.org/mailman/listinfo/python-checkins
>


More information about the Python-checkins mailing list