[Python-checkins] r63425 - in python/trunk: Lib/test/test_builtin.py Lib/test/test_py3kwarn.py Python/bltinmodule.c

[Benjamin Peterson]

On Sat, May 17, 2008 at 2:43 PM, Eric Smith
<eric+python-dev at trueblade.com> wrote:
> If I'm reading this change correctly, Guido previously said don't add this
> warning:
> http://mail.python.org/pipermail/python-dev/2008-February/077158.html
> "I think practicality says we should not warn about this."

I must have missed that message. If that's still the case, I will
revert it. I was working off issue 2337.

>
> I'm not sure about the PyNumber_ToBase change.  Why is that added to hex,
> and why isn't it added to oct?  That seems like a fairly significant change
> (and a gratuitous difference from oct).

You may have a point there. I though it fair to implement it for hex
because the format is the same, but that is not true for oct.


-- 
Cheers,
Benjamin Peterson
"There's no place like 127.0.0.1."