[Python-checkins] r71634 - in python/branches/release30-maint:Doc/library/subprocess.rst

R. David Murray rdmurray at bitdance.com
Thu Apr 16 02:35:00 CEST 2009

On Wed, 15 Apr 2009 at 15:51, Raymond Hettinger wrote:
> Stylistically, we should strongly prefer in-line comments and notes to the 
> ".. warning" directives.

I agree with you, and in fact I started out with a note.  However, the
fact is that if you replace the environment on Windows and don't specify
SystemRoot, then in general the program you try to call will not run.
A note felt too tame when I read it over.  It seemed to me that that
this rated a warning, and Georg was fine with it.

The person who analyzed the "bug" wanted to have subprocess automatically
add SystemRoot to the environment if it wasn't there, but doing that
seemed wrong to me.

I'll change it to a note if you still think a warning is excessive.
I agree that it could well be.


More information about the Python-checkins mailing list