[Python-checkins] r71862 - in python/branches/py3k: Lib/test/test_descr.py Misc/NEWS Objects/typeobject.c
benjamin.peterson
python-checkins at python.org
Sat Apr 25 03:08:45 CEST 2009
Author: benjamin.peterson
Date: Sat Apr 25 03:08:45 2009
New Revision: 71862
Log:
Merged revisions 71860 via svnmerge from
svn+ssh://pythondev@svn.python.org/python/trunk
........
r71860 | benjamin.peterson | 2009-04-24 19:41:22 -0500 (Fri, 24 Apr 2009) | 1 line
fix a segfault when setting __class__ in __del__ #5283
........
Modified:
python/branches/py3k/ (props changed)
python/branches/py3k/Lib/test/test_descr.py
python/branches/py3k/Misc/NEWS
python/branches/py3k/Objects/typeobject.c
Modified: python/branches/py3k/Lib/test/test_descr.py
==============================================================================
--- python/branches/py3k/Lib/test/test_descr.py (original)
+++ python/branches/py3k/Lib/test/test_descr.py Sat Apr 25 03:08:45 2009
@@ -2747,6 +2747,16 @@
continue
cant(cls(), cls2)
+ # Issue5283: when __class__ changes in __del__, the wrong
+ # type gets DECREF'd.
+ class O(object):
+ pass
+ class A(object):
+ def __del__(self):
+ self.__class__ = O
+ l = [A() for x in range(100)]
+ del l
+
def test_set_dict(self):
# Testing __dict__ assignment...
class C(object): pass
Modified: python/branches/py3k/Misc/NEWS
==============================================================================
--- python/branches/py3k/Misc/NEWS (original)
+++ python/branches/py3k/Misc/NEWS Sat Apr 25 03:08:45 2009
@@ -12,6 +12,8 @@
Core and Builtins
-----------------
+- Issue #5283: Setting __class__ in __del__ caused a segfault.
+
- Issue #5816: complex(repr(z)) now recovers z exactly, even when
z involves nans, infs or negative zeros.
Modified: python/branches/py3k/Objects/typeobject.c
==============================================================================
--- python/branches/py3k/Objects/typeobject.c (original)
+++ python/branches/py3k/Objects/typeobject.c Sat Apr 25 03:08:45 2009
@@ -877,6 +877,9 @@
assert(base);
}
+ /* Extract the type again; tp_del may have changed it */
+ type = Py_TYPE(self);
+
/* Call the base tp_dealloc() */
assert(basedealloc);
basedealloc(self);
@@ -958,6 +961,9 @@
}
}
+ /* Extract the type again; tp_del may have changed it */
+ type = Py_TYPE(self);
+
/* Call the base tp_dealloc(); first retrack self if
* basedealloc knows about gc.
*/
More information about the Python-checkins
mailing list