[Python-checkins] r69311 - sandbox/trunk/dbm_sqlite/alt/dbdict.py

raymond.hettinger python-checkins at python.org
Thu Feb 5 19:14:51 CET 2009


Author: raymond.hettinger
Date: Thu Feb  5 19:14:50 2009
New Revision: 69311

Log:
Simplify commit/rollback logic.

Modified:
   sandbox/trunk/dbm_sqlite/alt/dbdict.py

Modified: sandbox/trunk/dbm_sqlite/alt/dbdict.py
==============================================================================
--- sandbox/trunk/dbm_sqlite/alt/dbdict.py	(original)
+++ sandbox/trunk/dbm_sqlite/alt/dbdict.py	Thu Feb  5 19:14:50 2009
@@ -34,14 +34,11 @@
         tempname = filename + '.tmp'
         if self.flag != 'r':
             file = __builtins__.open(tempname, 'wb')
-            success = False
             try:
                 self.dump(file)
-                success = True
             finally:
                 file.close()
-            if success:
-                shutil.move(tempname, self.filename)
+            shutil.move(tempname, self.filename)    # atomic commit
             if self.mode:
                 os.chmod(self.filename, self.mode)
 


More information about the Python-checkins mailing list