[Python-checkins] r68153 - in python/trunk/Lib/idlelib: NEWS.txt help.txt macosxSupport.py

[ronald.oussoren]

Author: ronald.oussoren
Date: Fri Jan  2 13:59:32 2009
New Revision: 68153

Log:
Fix for issue3559: No preferences menu in IDLE on OSX

1) Add a comment to the help file to that points to the 
   preferences menu.

2) An earlier checkin tried to detect Tk >= 8.10.14,
   but did this in the wrong way. The end result of this
   was that the IDLE->Preferences... menu got surpressed
   when using the system version of Tcl/Tk


Modified:
   python/trunk/Lib/idlelib/NEWS.txt
   python/trunk/Lib/idlelib/help.txt
   python/trunk/Lib/idlelib/macosxSupport.py

Modified: python/trunk/Lib/idlelib/NEWS.txt
==============================================================================
--- python/trunk/Lib/idlelib/NEWS.txt	(original)
+++ python/trunk/Lib/idlelib/NEWS.txt	Fri Jan  2 13:59:32 2009
@@ -3,6 +3,8 @@
 
 *Release date: XX-XXX-2008*
 
+- Issue #3549: On MacOS the preferences menu was not present
+
 - Issue #2665: On Windows, an IDLE installation upgraded from an old version
   would not start if a custom theme was defined.
 

Modified: python/trunk/Lib/idlelib/help.txt
==============================================================================
--- python/trunk/Lib/idlelib/help.txt	(original)
+++ python/trunk/Lib/idlelib/help.txt	Fri Jan  2 13:59:32 2009
@@ -90,7 +90,10 @@
 	Configure IDLE -- Open a configuration dialog.  Fonts, indentation,
                           keybindings, and color themes may be altered.
                           Startup Preferences may be set, and Additional Help
-                          Souces can be specified.
+                          Sources can be specified.
+			  
+			  On MacOS X this menu is not present, use
+			  menu 'IDLE -> Preferences...' instead.
 	---
 	Code Context --	  Open a pane at the top of the edit window which
 			  shows the block context of the section of code

Modified: python/trunk/Lib/idlelib/macosxSupport.py
==============================================================================
--- python/trunk/Lib/idlelib/macosxSupport.py	(original)
+++ python/trunk/Lib/idlelib/macosxSupport.py	Fri Jan  2 13:59:32 2009
@@ -89,7 +89,9 @@
 
     ###check if Tk version >= 8.4.14; if so, use hard-coded showprefs binding
     tkversion = root.tk.eval('info patchlevel')
-    if tkversion >= '8.4.14':
+    # Note: we cannot check if the string tkversion >= '8.4.14', because
+    # the string '8.4.7' is greater than the string '8.4.14'.
+    if map(int, tkversion.split('.')) >= (8, 4, 14):
         Bindings.menudefs[0] =  ('application', [
                 ('About IDLE', '<<about-idle>>'),
                 None,