[Python-checkins] r68698 - in python/branches/py3k/Lib: importlib importlib/NOTES importlib/__init__.py importlib/_bootstrap.py importlib/test importlib/test/__init__.py importlib/test/builtin importlib/test/builtin/__init__.py importlib/test/bui

[Brett Cannon]

On Sat, Jan 17, 2009 at 19:13, Jim Jewett <jimjjewett at gmail.com> wrote:
> (1)  Shouldn't bytecode and data files be opened binary?
>

Yes, which is why they are.  =) I assume you are talking about
_fileio.FileIO, which only does bytes and thus does not need the 'b'
argument when opening.

> And as long as I'm picking nits anyhow...
>
> (2)  Some of the docstrings are a bit awkward around when to return
> None.   Consider "returning None ... unless ... " "returns None when
> ... not", or even "when none of ...", though I'll grant that
> distinguishing between "None" and "none" is also suboptimal.
>
> (3)  A spell check would get inerally and laoder, but would probably
> still miss "their" vs "there"

I am not worrying about the docstrings right now as they will be
cleaned up when I start to write the documentation and finish up the
refactorings I have planned.

-Brett