[Python-checkins] r70239 - in tracker/instances/python-dev: html/issue.item.html schema.py

martin.v.loewis python-checkins at python.org
Sun Mar 8 10:09:11 CET 2009


Author: martin.v.loewis
Date: Sun Mar  8 10:09:11 2009
New Revision: 70239

Log:
Issue #130: Allow creator to close his own issues.
Also fix permission check on assignee menu.


Modified:
   tracker/instances/python-dev/html/issue.item.html
   tracker/instances/python-dev/schema.py

Modified: tracker/instances/python-dev/html/issue.item.html
==============================================================================
--- tracker/instances/python-dev/html/issue.item.html	(original)
+++ tracker/instances/python-dev/html/issue.item.html	Sun Mar  8 10:09:11 2009
@@ -117,7 +117,7 @@
  </tr>
  <tr>
  <th><tal:block i18n:translate="">Assigned To</tal:block>:</th>
- <td tal:condition="context/status/is_edit_ok">
+ <td tal:condition="context/assignee/is_edit_ok">
   <select name="assignee">
    <option value="-1">nobody</option>
    <tal:block tal:repeat="userdata python:db._db.user.filter_sql('select id,_username from _user where _roles like \'%Developer%\' order by _username')">

Modified: tracker/instances/python-dev/schema.py
==============================================================================
--- tracker/instances/python-dev/schema.py	(original)
+++ tracker/instances/python-dev/schema.py	Sun Mar  8 10:09:11 2009
@@ -236,6 +236,15 @@
                               description='User can report and discuss issues')
 db.security.addPermissionToRole('User', p)
 
+# Allow users to close issues they created
+def close_own_issue(db, userid, itemid):
+    return userid == db.issue.get(itemid, 'creator')
+p = db.security.addPermission(name='Edit', klass='issue',
+                              properties=('status',),
+                              description='User can close issues he created',
+                              check=close_own_issue)
+db.security.addPermissionToRole('User', p)
+
 db.security.addPermissionToRole('User', 'SB: May Report Misclassified')
 
 


More information about the Python-checkins mailing list