[Python-checkins] r70881 - in python/branches/release26-maint: Lib/test/test_mmap.py Modules/mmapmodule.c
hirokazu.yamamoto
python-checkins at python.org
Tue Mar 31 22:22:13 CEST 2009
Author: hirokazu.yamamoto
Date: Tue Mar 31 22:22:13 2009
New Revision: 70881
Log:
Merged revisions 70879 via svnmerge from
svn+ssh://pythondev@svn.python.org/python/trunk
........
r70879 | hirokazu.yamamoto | 2009-04-01 05:14:04 +0900 | 1 line
Issue #5387: Fixed mmap.move crash by integer overflow. (take2)
........
Modified:
python/branches/release26-maint/ (props changed)
python/branches/release26-maint/Lib/test/test_mmap.py
python/branches/release26-maint/Modules/mmapmodule.c
Modified: python/branches/release26-maint/Lib/test/test_mmap.py
==============================================================================
--- python/branches/release26-maint/Lib/test/test_mmap.py (original)
+++ python/branches/release26-maint/Lib/test/test_mmap.py Tue Mar 31 22:22:13 2009
@@ -1,7 +1,7 @@
from test.test_support import TESTFN, run_unittest
import mmap
import unittest
-import os, re
+import os, re, itertools
PAGESIZE = mmap.PAGESIZE
@@ -350,9 +350,21 @@
self.assertEqual(m[:], expected)
m.close()
- # should not crash
- m = mmap.mmap(-1, 1)
- self.assertRaises(ValueError, m.move, 1, 1, -1)
+ # segfault test (Issue 5387)
+ m = mmap.mmap(-1, 100)
+ offsets = [-100, -1, 0, 1, 100]
+ for source, dest, size in itertools.product(offsets, offsets, offsets):
+ try:
+ m.move(source, dest, size)
+ except ValueError:
+ pass
+ self.assertRaises(ValueError, m.move, -1, -1, -1)
+ self.assertRaises(ValueError, m.move, -1, -1, 0)
+ self.assertRaises(ValueError, m.move, -1, 0, -1)
+ self.assertRaises(ValueError, m.move, 0, -1, -1)
+ self.assertRaises(ValueError, m.move, -1, 0, 0)
+ self.assertRaises(ValueError, m.move, 0, -1, 0)
+ self.assertRaises(ValueError, m.move, 0, 0, -1)
m.close()
def test_anonymous(self):
Modified: python/branches/release26-maint/Modules/mmapmodule.c
==============================================================================
--- python/branches/release26-maint/Modules/mmapmodule.c (original)
+++ python/branches/release26-maint/Modules/mmapmodule.c Tue Mar 31 22:22:13 2009
@@ -617,7 +617,7 @@
} else {
/* bounds check the values */
unsigned long pos = src > dest ? src : dest;
- if (self->size >= pos && count > self->size - pos) {
+ if (self->size < pos || count > self->size - pos) {
PyErr_SetString(PyExc_ValueError,
"source or destination out of range");
return NULL;
More information about the Python-checkins
mailing list