[Python-checkins] r72594 - in python/branches/release26-maint: Lib/distutils/command/build_ext.py

[Tarek Ziadé]

On Tue, May 12, 2009 at 11:20 PM, benjamin.peterson
<python-checkins at python.org> wrote:
>  the compiler attribute is used in setup.py; can't rename

Can't we rename it there as well ? "compiler" is an option (str) in
build_ext, and shouldn't be turned into a compiler instance.


> -        self._compiler = new_compiler(compiler=self.compiler,
> +        self.compiler = new_compiler(compiler=None,

You are braking the option here with that change, e.g. you can't force
a compiler type
anymore as it is supposed to be.

So I think we have to make a choice : either it's a string, either
it's a compiler instance,
but it can't be both

Tarek
-- 
Tarek Ziadé | http://ziade.org