[Python-checkins] r76588 - in python/trunk: Lib/distutils/tests/test_sdist.py Misc/NEWS

tarek.ziade python-checkins at python.org
Sun Nov 29 23:20:30 CET 2009


Author: tarek.ziade
Date: Sun Nov 29 23:20:30 2009
New Revision: 76588

Log:
Fixed #7408: dropped group ownership checking because it relies on os-specific rules

Modified:
   python/trunk/Lib/distutils/tests/test_sdist.py
   python/trunk/Misc/NEWS

Modified: python/trunk/Lib/distutils/tests/test_sdist.py
==============================================================================
--- python/trunk/Lib/distutils/tests/test_sdist.py	(original)
+++ python/trunk/Lib/distutils/tests/test_sdist.py	Sun Nov 29 23:20:30 2009
@@ -336,10 +336,13 @@
         # making sure we have the good rights
         archive_name = join(self.tmp_dir, 'dist', 'fake-1.0.tar.gz')
         archive = tarfile.open(archive_name)
+
+        # note that we are not testing the group ownership here
+        # because, depending on the platforms and the container
+        # rights (see #7408)
         try:
             for member in archive.getmembers():
                 self.assertEquals(member.uid, os.getuid())
-                self.assertEquals(member.gid, os.getgid())
         finally:
             archive.close()
 

Modified: python/trunk/Misc/NEWS
==============================================================================
--- python/trunk/Misc/NEWS	(original)
+++ python/trunk/Misc/NEWS	Sun Nov 29 23:20:30 2009
@@ -487,6 +487,10 @@
 Library
 -------
 
+- Issue #7408: Fixed distutils.tests.sdist so it doesn't check for group
+  ownership when the group is not forced, because the group may be different
+  from the user's group and inherit from its container when the test is run.
+
 - Issue #1515: Enable use of deepcopy() with instance methods.  Patch by
   Robert Collins.
 


More information about the Python-checkins mailing list