[Python-checkins] r80166 - python/trunk/Lib/platform.py

Antoine Pitrou solipsis at pitrou.net
Sun Apr 18 13:19:48 CEST 2010


<victor.stinner> writes:
> 
> Author: victor.stinner
> Date: Sun Apr 18 11:07:49 2010
> New Revision: 80166
> 
> Log:
> platform: use subprocess.Popen() instead of os.popen() in _syscmd_file()


Victor, your commit broke compilation on all non-Windows buildbots.
Also, there are now three flavours of popen() in platform.py (os.popen,
subprocess.Popen, and a homegrown one). This would deserve some cleanup.

Thanks

Antoine.




More information about the Python-checkins mailing list