[Python-checkins] r80228 - in python/branches/py3k: Lib/ftplib.py Misc/NEWS

giampaolo.rodola python-checkins at python.org
Tue Apr 20 00:05:54 CEST 2010


Author: giampaolo.rodola
Date: Tue Apr 20 00:05:54 2010
New Revision: 80228

Log:
Merged revisions 80226 via svnmerge from 
svn+ssh://pythondev@svn.python.org/python/trunk

........
  r80226 | giampaolo.rodola | 2010-04-19 23:46:28 +0200 (lun, 19 apr 2010) | 1 line
  
  Fix Issue #4841: timeout is now applied for connections resulting from PORT/EPRT commands
........


Modified:
   python/branches/py3k/   (props changed)
   python/branches/py3k/Lib/ftplib.py
   python/branches/py3k/Misc/NEWS

Modified: python/branches/py3k/Lib/ftplib.py
==============================================================================
--- python/branches/py3k/Lib/ftplib.py	(original)
+++ python/branches/py3k/Lib/ftplib.py	Tue Apr 20 00:05:54 2010
@@ -297,6 +297,8 @@
             resp = self.sendport(host, port)
         else:
             resp = self.sendeprt(host, port)
+        if self.timeout is not _GLOBAL_DEFAULT_TIMEOUT:
+            sock.settimeout(self.timeout)
         return sock
 
     def makepasv(self):
@@ -349,6 +351,8 @@
             if resp[0] != '1':
                 raise error_reply(resp)
             conn, sockaddr = sock.accept()
+            if self.timeout is not _GLOBAL_DEFAULT_TIMEOUT:
+                conn.settimeout(self.timeout)
         if resp[:3] == '150':
             # this is conditional in case we received a 125
             size = parse150(resp)

Modified: python/branches/py3k/Misc/NEWS
==============================================================================
--- python/branches/py3k/Misc/NEWS	(original)
+++ python/branches/py3k/Misc/NEWS	Tue Apr 20 00:05:54 2010
@@ -318,6 +318,9 @@
 Library
 -------
 
+- Issue #4814: timeout parameter is now applied also for connections resulting
+  from PORT/EPRT commands.
+
 - Issue #8463: added missing reference to bztar in shutil's documentation.
 
 - Issue #7154: urllib.request can now detect the proxy settings on OSX 10.6


More information about the Python-checkins mailing list