[Python-checkins] r80480 - python/trunk/Lib/test/test_httpservers.py

[antoine.pitrou]

Author: antoine.pitrou
Date: Sun Apr 25 23:15:50 2010
New Revision: 80480

Log:
Replace a Lock with a better suited Event.



Modified:
   python/trunk/Lib/test/test_httpservers.py

Modified: python/trunk/Lib/test/test_httpservers.py
==============================================================================
--- python/trunk/Lib/test/test_httpservers.py	(original)
+++ python/trunk/Lib/test/test_httpservers.py	Sun Apr 25 23:15:50 2010
@@ -33,14 +33,14 @@
         threading.Thread.__init__(self)
         self.request_handler = request_handler
         self.test_object = test_object
-        self.test_object.lock.acquire()
 
     def run(self):
         self.server = HTTPServer(('', 0), self.request_handler)
         self.test_object.PORT = self.server.socket.getsockname()[1]
-        self.test_object.lock.release()
+        self.test_object.server_started.set()
+        self.test_object = None
         try:
-            self.server.serve_forever()
+            self.server.serve_forever(0.05)
         finally:
             self.server.server_close()
 
@@ -52,13 +52,12 @@
     def setUp(self):
         self._threads = test_support.threading_setup()
         os.environ = test_support.EnvironmentVarGuard()
-        self.lock = threading.Lock()
+        self.server_started = threading.Event()
         self.thread = TestServerThread(self, self.request_handler)
         self.thread.start()
-        self.lock.acquire()
+        self.server_started.wait()
 
     def tearDown(self):
-        self.lock.release()
         self.thread.stop()
         os.environ.__exit__()
         test_support.threading_cleanup(*self._threads)