[Python-checkins] r83643 - in python/branches/release27-maint: Lib/test/test_posix.py

ronald.oussoren python-checkins at python.org
Tue Aug 3 09:31:12 CEST 2010


Author: ronald.oussoren
Date: Tue Aug  3 09:31:12 2010
New Revision: 83643

Log:
Merged revisions 83431 via svnmerge from 
svn+ssh://pythondev@svn.python.org/python/branches/py3k

........
  r83431 | ronald.oussoren | 2010-08-01 21:18:13 +0200 (Sun, 01 Aug 2010) | 6 lines
  
  
  test_getgroups as introduced with issue7900 failed on systems
  where 'id -G' and posix.getgroups() returned the same information,
  but one of the sources contains duplicate information. Rewrite the
  check using sets instead of lists.
........


Modified:
   python/branches/release27-maint/   (props changed)
   python/branches/release27-maint/Lib/test/test_posix.py

Modified: python/branches/release27-maint/Lib/test/test_posix.py
==============================================================================
--- python/branches/release27-maint/Lib/test/test_posix.py	(original)
+++ python/branches/release27-maint/Lib/test/test_posix.py	Tue Aug  3 09:31:12 2010
@@ -371,11 +371,11 @@
         if not groups:
             raise unittest.SkipTest("need working 'id -G'")
 
-        # The order of groups isn't important, hence the calls
-        # to sorted.
+        # 'id -G' and 'os.getgroups()' should return the same
+        # groups, ignoring order and duplicates.
         self.assertEqual(
-                list(sorted([int(x) for x in groups.split()])),
-                list(sorted(posix.getgroups())))
+                set([int(x) for x in groups.split()]),
+                set(posix.getgroups()))
 
 class PosixGroupsTester(unittest.TestCase):
 


More information about the Python-checkins mailing list