[Python-checkins] r83899 - in tracker/instances/python-dev/extensions: local_replace.py test/test_local_replace.py

ezio.melotti python-checkins at python.org
Mon Aug 9 20:58:53 CEST 2010


Author: ezio.melotti
Date: Mon Aug  9 20:58:53 2010
New Revision: 83899

Log:
Tweak regex to avoid linking to revisions when they appear in the query string of an URL.

Modified:
   tracker/instances/python-dev/extensions/local_replace.py
   tracker/instances/python-dev/extensions/test/test_local_replace.py

Modified: tracker/instances/python-dev/extensions/local_replace.py
==============================================================================
--- tracker/instances/python-dev/extensions/local_replace.py	(original)
+++ tracker/instances/python-dev/extensions/local_replace.py	Mon Aug  9 20:58:53 2010
@@ -6,7 +6,7 @@
 
 substitutions = [
     #  r12345, r 12345, rev12345, rev 12345, revision12345, revision 12345
-    (re.compile(r'\b(?<!/)(?P<revstr>r(ev(ision)?)?\s*)(?P<revision>\d+)'),
+    (re.compile(r'\b(?<![/?&;])(?P<revstr>r(ev(ision)?)?\s*)(?P<revision>\d+)'),
      r'<a href="http://svn.python.org/view?rev=\g<revision>'
      r'&view=rev">\g<revstr>\g<revision></a>'),
 

Modified: tracker/instances/python-dev/extensions/test/test_local_replace.py
==============================================================================
--- tracker/instances/python-dev/extensions/test/test_local_replace.py	(original)
+++ tracker/instances/python-dev/extensions/test/test_local_replace.py	Mon Aug  9 20:58:53 2010
@@ -120,6 +120,12 @@
       'http://svn.python.org/view/python/tags/r265/Lib/cgi.py?view=markup</a>')),
     ('http://bugs.python.org/issue1000',
      '<a href="http://bugs.python.org/issue1000">http://bugs.python.org/issue1000</a>'),
+    ('http://svn.python.org/view/python/branches/release26-maint'
+     '/Lib/socket.py?r1=83624&r2=83623&pathrev=83624',
+     '<a href="http://svn.python.org/view/python/branches/release26-maint/'
+     'Lib/socket.py?r1=83624&amp;r2=83623&amp;pathrev=83624">http://svn.python.org/'
+     'view/python/branches/release26-maint/Lib/socket.py'
+     '?r1=83624&amp;r2=83623&amp;pathrev=83624</a>'),
 
     ## emails
     ('fixed at europython.eu',


More information about the Python-checkins mailing list