[Python-checkins] r83922 - in python/branches/release31-maint: Misc/ACKS Misc/NEWS Modules/posixmodule.c

antoine.pitrou python-checkins at python.org
Tue Aug 10 01:47:57 CEST 2010


Author: antoine.pitrou
Date: Tue Aug 10 01:47:57 2010
New Revision: 83922

Log:
Merged revisions 83921 via svnmerge from 
svn+ssh://pythondev@svn.python.org/python/branches/py3k

........
  r83921 | antoine.pitrou | 2010-08-10 01:39:31 +0200 (mar., 10 août 2010) | 4 lines
  
  Issue #6915: Under Windows, os.listdir() didn't release the Global
  Interpreter Lock around all system calls.  Original patch by Ryan Kelly.
........


Modified:
   python/branches/release31-maint/   (props changed)
   python/branches/release31-maint/Misc/ACKS
   python/branches/release31-maint/Misc/NEWS
   python/branches/release31-maint/Modules/posixmodule.c

Modified: python/branches/release31-maint/Misc/ACKS
==============================================================================
--- python/branches/release31-maint/Misc/ACKS	(original)
+++ python/branches/release31-maint/Misc/ACKS	Tue Aug 10 01:47:57 2010
@@ -398,6 +398,7 @@
 Lou Kates
 Hiroaki Kawai
 Sebastien Keim
+Ryan Kelly
 Robert Kern
 Randall Kern
 Magnus Kessler

Modified: python/branches/release31-maint/Misc/NEWS
==============================================================================
--- python/branches/release31-maint/Misc/NEWS	(original)
+++ python/branches/release31-maint/Misc/NEWS	Tue Aug 10 01:47:57 2010
@@ -98,6 +98,9 @@
 Library
 -------
 
+- Issue #6915: Under Windows, os.listdir() didn't release the Global
+  Interpreter Lock around all system calls.  Original patch by Ryan Kelly.
+
 - Issue #3757: thread-local objects now support cyclic garbage collection.
   Thread-local objects involved in reference cycles will be deallocated
   timely by the cyclic GC, even if the underlying thread is still running.

Modified: python/branches/release31-maint/Modules/posixmodule.c
==============================================================================
--- python/branches/release31-maint/Modules/posixmodule.c	(original)
+++ python/branches/release31-maint/Modules/posixmodule.c	Tue Aug 10 01:47:57 2010
@@ -2270,7 +2270,9 @@
                 free(wnamebuf);
                 return NULL;
             }
+            Py_BEGIN_ALLOW_THREADS
             hFindFile = FindFirstFileW(wnamebuf, &wFileData);
+            Py_END_ALLOW_THREADS
             if (hFindFile == INVALID_HANDLE_VALUE) {
                 int error = GetLastError();
                 if (error == ERROR_FILE_NOT_FOUND) {
@@ -2348,7 +2350,9 @@
     if ((d = PyList_New(0)) == NULL)
         return NULL;
 
+    Py_BEGIN_ALLOW_THREADS
     hFindFile = FindFirstFile(namebuf, &FileData);
+    Py_END_ALLOW_THREADS
     if (hFindFile == INVALID_HANDLE_VALUE) {
         int error = GetLastError();
         if (error == ERROR_FILE_NOT_FOUND)


More information about the Python-checkins mailing list