[Python-checkins] distutils2: made sure that the coverage report is accurate even when ran outsite of a venv

[tarek.ziade]

tarek.ziade pushed 39220974a1e4 to distutils2:

http://hg.python.org/distutils2/rev/39220974a1e4
changeset:   377:39220974a1e4
parent:      375:fdc0f44dc5ec
user:        Yannick Gingras <ygingras at ygingras.net>
date:        Fri Jul 16 01:33:03 2010 -0400
summary:     made sure that the coverage report is accurate even when ran outsite of a venv
files:       src/runtests-cov.py

diff --git a/src/runtests-cov.py b/src/runtests-cov.py
--- a/src/runtests-cov.py
+++ b/src/runtests-cov.py
@@ -4,20 +4,23 @@
 The tests for distutils2 are defined in the distutils2.tests package.
 """
 
-# TODO:
+import sys
+from os.path import dirname, islink, realpath
+from optparse import OptionParser
 
-# The coverage report is only accurate when ran inside a virtualenv
-# created with the --no-site-packages option.  When it's not the case,
-# the built-in ignore list is not accurate and third party packages
-# show-up in the report, lowering the overall coverage.  
-
-# One particular problem it docutils on Ubuntu which has a __file__
-# starting with /usr/lib/python2.6 while the path in the coverage
-# report starts with /usr/share/pyshared.
-
-import sys
-from os.path import dirname
-from optparse import OptionParser
+def ignore_prefixes(module):
+    """ Return a list of prefixes to ignore in the coverage report if
+    we want to completely skip `module`.
+    """
+    # A function like that is needed because some GNU/Linux
+    # distributions, such a Ubuntu, really like to build link farm in
+    # /usr/lib in order to save a few bytes on the disk.
+    dirnames = [dirname(module.__file__)]
+    
+    pymod = module.__file__.rstrip("c")
+    if islink(pymod):
+        dirnames.append(dirname(realpath(pymod)))
+    return dirnames
 
 def parse_opts():
     parser = OptionParser(usage="%prog [OPTIONS]", 
@@ -40,16 +43,27 @@
 def coverage_report(opts):
     import coverage
     import unittest2
-    import docutils
     cov = coverage.coverage()
     cov.load()
 
-    cov.report(omit_prefixes=["distutils2/tests", 
-                              "runtests", 
-                              "distutils2/_backport", 
-                              dirname(unittest2.__file__),
-                              dirname(dirname(docutils.__file__))], 
-               show_missing=opts.show_missing)
+    prefixes = ["runtests", "distutils2/tests", "distutils2/_backport"]
+    prefixes += ignore_prefixes(unittest2)
+
+    try:
+        import docutils
+        prefixes += ignore_prefixes(docutils)
+    except ImportError:
+        # that module is completely optional
+        pass
+
+    try:
+        import roman
+        prefixes += ignore_prefixes(roman)
+    except ImportError:
+        # that module is also completely optional
+        pass
+
+    cov.report(omit_prefixes=prefixes, show_missing=opts.show_missing)
 
 
 def test_main():

--
Repository URL: http://hg.python.org/distutils2