[Python-checkins] r83248 - python/branches/import_unicode/Modules/zipimport.c

[Victor Stinner]

Le vendredi 30 juillet 2010 03:21:56, Alexander Belopolsky a écrit :
> On Thu, Jul 29, 2010 at 8:47 PM, victor.stinner
> <python-checkins at python.org> wrote:
> ..
> 
> > +        res = PyUnicode_DecodeFSDefault(PyBytes_AsString(bytes));
> 
> Shouldn't you check return value of PyBytes_AsString before passing it
> to PyUnicode_DecodeFSDefault?

I would be better, but it's not important here, because bytes should be a 
PyBytesObjects (result of get_data). I didn't wrote this code and I prefer to 
not change to much code if it's possible.

Please patch zipimport.c in py3k directly.

-- 
Victor Stinner
http://www.haypocalc.com/