[Python-checkins] r79268 - in python/trunk/Lib: test/test_unittest.py unittest/loader.py unittest/main.py

[michael.foord]

Author: michael.foord
Date: Mon Mar 22 02:41:11 2010
New Revision: 79268

Log:
Removing Python 2.3 compatibility code from unittest.

Modified:
   python/trunk/Lib/test/test_unittest.py
   python/trunk/Lib/unittest/loader.py
   python/trunk/Lib/unittest/main.py

Modified: python/trunk/Lib/test/test_unittest.py
==============================================================================
--- python/trunk/Lib/test/test_unittest.py	(original)
+++ python/trunk/Lib/test/test_unittest.py	Mon Mar 22 02:41:11 2010
@@ -4021,13 +4021,15 @@
         program._do_discovery(['-p', 'fish'], Loader=Loader)
         self.assertEqual(program.test, 'tests')
         self.assertEqual(Loader.args, [('.', 'fish', None)])
+        self.assertFalse(program.failfast)
 
         Loader.args = []
         program = object.__new__(TestProgram)
-        program._do_discovery(['-p', 'eggs', '-s', 'fish', '-v'], Loader=Loader)
+        program._do_discovery(['-p', 'eggs', '-s', 'fish', '-v', '-f'], Loader=Loader)
         self.assertEqual(program.test, 'tests')
         self.assertEqual(Loader.args, [('fish', 'eggs', None)])
         self.assertEqual(program.verbosity, 2)
+        self.assertTrue(program.failfast)
 
 
 class TestSetups(unittest.TestCase):

Modified: python/trunk/Lib/unittest/loader.py
==============================================================================
--- python/trunk/Lib/unittest/loader.py	(original)
+++ python/trunk/Lib/unittest/loader.py	Mon Mar 22 02:41:11 2010
@@ -30,11 +30,7 @@
 
 
 def _make_failed_import_test(name, suiteClass):
-    message = 'Failed to import test module: %s' % name
-    if hasattr(traceback, 'format_exc'):
-        # Python 2.3 compatibility
-        # format_exc returns two frames of discover.py as well
-        message += '\n%s' % traceback.format_exc()
+    message = 'Failed to import test module: %s\n%s' % (name, traceback.format_exc())
     return _make_failed_test('ModuleImportFailure', name, ImportError(message),
                              suiteClass)
 

Modified: python/trunk/Lib/unittest/main.py
==============================================================================
--- python/trunk/Lib/unittest/main.py	(original)
+++ python/trunk/Lib/unittest/main.py	Mon Mar 22 02:41:11 2010
@@ -159,10 +159,9 @@
         for name, value in zip(('start', 'pattern', 'top'), args):
             setattr(options, name, value)
 
+        self.failfast = options.failfast
         if options.verbose:
             self.verbosity = 2
-        if options.failfast:
-            self.failfast = True
 
         start_dir = options.start
         pattern = options.pattern