[Python-checkins] r80816 - python/trunk/Python/getcwd.c

[Brett Cannon]

On Wed, May 5, 2010 at 13:58, Victor Stinner
<victor.stinner at haypocalc.com>wrote:

> Le mercredi 05 mai 2010 22:26:58, brett.cannon a écrit :
> > Author: brett.cannon
> > Date: Wed May  5 22:26:58 2010
> > New Revision: 80816
> >
> > Log:
> > Remove an unneeded variable and fix a little whitespace.
>
> Please, could you try to fix one thing by commit. I mean: one commit for
> the
> variable, and another for the whitespaces.
>

It was a choice over getting this done or having very clean commits; I chose
the former obviously. Probably would have bothered had svn let me shelve
changes like Hg's mq would have let me.


>
> > Found using Clang's static analyzer.
>
> Whitespaces are not related to the static analyzer.
>
>
> It would be better to fix all whitespaces in ONE unique commit on the whole
> Python project, instead of fix some whitespaces in some files. Antoine is
> working on a tool to uniformize the indentation (and spaces) of the C
> files.


That's fine, but I believe that is being aimed at four space indents; I
don't know if he is planning a separate run just to clean up extraneous
whitespace. Plus that will probably only be run on py3k and not trunk. I am
not going to wait when I have the whitespace staring me in the face while I
am editing the code as who knows if Antoine will have the time to ever run
it on 2.7.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.python.org/pipermail/python-checkins/attachments/20100505/57e6ba76/attachment.html>