[Python-checkins] r81102 - python/trunk/Lib/test/test_asyncore.py

giampaolo.rodola python-checkins at python.org
Wed May 12 02:29:27 CEST 2010


Author: giampaolo.rodola
Date: Wed May 12 02:29:27 2010
New Revision: 81102

Log:
Removed the assertion that dispatcher.connected attribute must be False after a single connect() call. Solaris and FreeBSD buildbots failures showed how connect() can succeed even in a single call. All bo failures should definitively be fixed now.

Modified:
   python/trunk/Lib/test/test_asyncore.py

Modified: python/trunk/Lib/test/test_asyncore.py
==============================================================================
--- python/trunk/Lib/test/test_asyncore.py	(original)
+++ python/trunk/Lib/test/test_asyncore.py	Wed May 12 02:29:27 2010
@@ -618,12 +618,8 @@
         # we start disconnected
         self.assertFalse(server.connected)
         self.assertTrue(server.accepting)
-        # XXX - Solaris seems to connect() immediately even without
-        # starting the poller. This is something which should be
-        # fixed as handle_connect() gets called immediately even if
-        # no connection actually took place (see issue #8490).
-        if not sys.platform.startswith("sunos"):
-            self.assertFalse(client.connected)
+        # this can't be taken for granted across all platforms
+        #self.assertFalse(client.connected)
         self.assertFalse(client.accepting)
 
         # execute some loops so that client connects to server


More information about the Python-checkins mailing list