[Python-checkins] r86203 - in python/branches/release27-maint: Lib/test/test_quopri.py

brian.curtin python-checkins at python.org
Fri Nov 5 16:42:57 CET 2010


Author: brian.curtin
Date: Fri Nov  5 16:42:57 2010
New Revision: 86203

Log:
Merged revisions 86202 via svnmerge from 
svn+ssh://pythondev@svn.python.org/python/branches/py3k

........
  r86202 | brian.curtin | 2010-11-05 10:40:27 -0500 (Fri, 05 Nov 2010) | 2 lines
  
  Fix ResourceWarning from subprocess pipes being left open.
........


Modified:
   python/branches/release27-maint/   (props changed)
   python/branches/release27-maint/Lib/test/test_quopri.py

Modified: python/branches/release27-maint/Lib/test/test_quopri.py
==============================================================================
--- python/branches/release27-maint/Lib/test/test_quopri.py	(original)
+++ python/branches/release27-maint/Lib/test/test_quopri.py	Fri Nov  5 16:42:57 2010
@@ -178,6 +178,7 @@
         (p, e) = self.STRINGS[-1]
         process = subprocess.Popen([sys.executable, "-mquopri"],
                                    stdin=subprocess.PIPE, stdout=subprocess.PIPE)
+        self.addCleanup(process.stdout.close)
         cout, cerr = process.communicate(p)
         # On Windows, Python will output the result to stdout using
         # CRLF, as the mode of stdout is text mode. To compare this
@@ -188,6 +189,7 @@
         (p, e) = self.STRINGS[-1]
         process = subprocess.Popen([sys.executable, "-mquopri", "-d"],
                                    stdin=subprocess.PIPE, stdout=subprocess.PIPE)
+        self.addCleanup(process.stdout.close)
         cout, cerr = process.communicate(e)
         self.assertEqual(cout.splitlines(), p.splitlines())
 


More information about the Python-checkins mailing list