[Python-checkins] r85961 - python/branches/py3k/Lib/test/test_minidom.py

brett.cannon python-checkins at python.org
Sat Oct 30 02:14:59 CEST 2010


Author: brett.cannon
Date: Sat Oct 30 02:14:59 2010
New Revision: 85961

Log:
Properly close a file in test_minidom.

Modified:
   python/branches/py3k/Lib/test/test_minidom.py

Modified: python/branches/py3k/Lib/test/test_minidom.py
==============================================================================
--- python/branches/py3k/Lib/test/test_minidom.py	(original)
+++ python/branches/py3k/Lib/test/test_minidom.py	Sat Oct 30 02:14:59 2010
@@ -73,9 +73,10 @@
         self.confirm(t == s, "looking for %s, found %s" % (repr(s), repr(t)))
 
     def testParseFromFile(self):
-        dom = parse(open(tstfile))
-        dom.unlink()
-        self.confirm(isinstance(dom, Document))
+        with open(tstfile) as file:
+            dom = parse(file)
+            dom.unlink()
+            self.confirm(isinstance(dom, Document))
 
     def testGetElementsByTagName(self):
         dom = parse(tstfile)


More information about the Python-checkins mailing list