[Python-checkins] r84492 - python/branches/py3k/Lib/test/test_posix.py

antoine.pitrou python-checkins at python.org
Sat Sep 4 19:32:06 CEST 2010


Author: antoine.pitrou
Date: Sat Sep  4 19:32:06 2010
New Revision: 84492

Log:
Issue #9581: Fix non-working PosixGroupsTester test case
(it only runs as root, which is why nobody bothered about the failure)



Modified:
   python/branches/py3k/Lib/test/test_posix.py

Modified: python/branches/py3k/Lib/test/test_posix.py
==============================================================================
--- python/branches/py3k/Lib/test/test_posix.py	(original)
+++ python/branches/py3k/Lib/test/test_posix.py	Sat Sep  4 19:32:06 2010
@@ -409,13 +409,7 @@
     def test_initgroups(self):
         # find missing group
 
-        groups = sorted(self.saved_groups)
-        for g1,g2 in zip(groups[:-1], groups[1:]):
-            g = g1 + 1
-            if g < g2:
-                break
-        else:
-            g = g2 + 1
+        g = max(self.saved_groups) + 1
         name = pwd.getpwuid(posix.getuid()).pw_name
         posix.initgroups(name, g)
         self.assertIn(g, posix.getgroups())
@@ -423,7 +417,7 @@
     @unittest.skipUnless(hasattr(posix, 'setgroups'),
                          "test needs posix.setgroups()")
     def test_setgroups(self):
-        for groups in [[0], range(16)]:
+        for groups in [[0], list(range(16))]:
             posix.setgroups(groups)
             self.assertListEqual(groups, posix.getgroups())
 


More information about the Python-checkins mailing list