[Python-checkins] cpython (3.1): make assigning to a bytes literal a syntax error (closes #11506)

benjamin.peterson python-checkins at python.org
Wed Apr 13 01:33:58 CEST 2011


http://hg.python.org/cpython/rev/4d9a8e84279a
changeset:   69288:4d9a8e84279a
branch:      3.1
parent:      69277:707078ca0a77
user:        Benjamin Peterson <benjamin at python.org>
date:        Tue Apr 12 18:33:28 2011 -0500
summary:
  make assigning to a bytes literal a syntax error (closes #11506)

files:
  Lib/test/test_syntax.py |  4 ++++
  Misc/NEWS               |  3 +++
  Python/ast.c            |  1 +
  3 files changed, 8 insertions(+), 0 deletions(-)


diff --git a/Lib/test/test_syntax.py b/Lib/test/test_syntax.py
--- a/Lib/test/test_syntax.py
+++ b/Lib/test/test_syntax.py
@@ -67,6 +67,10 @@
 Traceback (most recent call last):
 SyntaxError: can't assign to literal
 
+>>> b"" = 1
+Traceback (most recent call last):
+SyntaxError: can't assign to literal
+
 >>> `1` = 1
 Traceback (most recent call last):
 SyntaxError: invalid syntax
diff --git a/Misc/NEWS b/Misc/NEWS
--- a/Misc/NEWS
+++ b/Misc/NEWS
@@ -45,6 +45,9 @@
 - Issue #5587: add a repr to dict_proxy objects.  Patch by David Stanek and
   Daniel Urban.
 
+- Issue #11506: Trying to assign to a bytes literal should result in a
+  SyntaxError.
+
 Library
 -------
 
diff --git a/Python/ast.c b/Python/ast.c
--- a/Python/ast.c
+++ b/Python/ast.c
@@ -469,6 +469,7 @@
         case Set_kind:
         case Num_kind:
         case Str_kind:
+        case Bytes_kind:
             expr_name = "literal";
             break;
         case Ellipsis_kind:

-- 
Repository URL: http://hg.python.org/cpython


More information about the Python-checkins mailing list