[Python-checkins] cpython (merge 3.2 -> default): Issue #12650: fix failures on some buildbots, when a subprocess takes a long

charles-francois.natali python-checkins at python.org
Fri Aug 19 00:25:36 CEST 2011


http://hg.python.org/cpython/rev/a32ae2749cd1
changeset:   71911:a32ae2749cd1
parent:      71909:b2c6c65d59f6
parent:      71910:122f952add3c
user:        Charles-François Natali <neologix at free.fr>
date:        Fri Aug 19 00:25:07 2011 +0200
summary:
  Issue #12650: fix failures on some buildbots, when a subprocess takes a long
time to spawn.

files:
  Lib/test/test_subprocess.py |  12 ------------
  1 files changed, 0 insertions(+), 12 deletions(-)


diff --git a/Lib/test/test_subprocess.py b/Lib/test/test_subprocess.py
--- a/Lib/test/test_subprocess.py
+++ b/Lib/test/test_subprocess.py
@@ -1507,18 +1507,6 @@
         # check that p is in the active processes list
         self.assertIn(ident, [id(o) for o in subprocess._active])
 
-        # sleep a little to let the process exit, and create a new Popen: this
-        # should trigger the wait() of p
-        time.sleep(1)
-        with self.assertRaises(EnvironmentError) as c:
-            with subprocess.Popen(['nonexisting_i_hope'],
-                                  stdout=subprocess.PIPE,
-                                  stderr=subprocess.PIPE) as proc:
-                pass
-        # p should have been wait()ed on, and removed from the _active list
-        self.assertRaises(OSError, os.waitpid, pid, 0)
-        self.assertNotIn(ident, [id(o) for o in subprocess._active])
-
     def test_leak_fast_process_del_killed(self):
         # Issue #12650: on Unix, if Popen.__del__() was called before the
         # process exited, and the process got killed by a signal, it would never

-- 
Repository URL: http://hg.python.org/cpython


More information about the Python-checkins mailing list