[Python-checkins] cpython (3.2): Minor code style improvements in http.server suggested in Issue13294.

senthil.kumaran python-checkins at python.org
Fri Dec 23 10:09:57 CET 2011


http://hg.python.org/cpython/rev/2c1720468dbb
changeset:   74138:2c1720468dbb
branch:      3.2
parent:      74135:9c19df6c8ea0
user:        Senthil Kumaran <senthil at uthcode.com>
date:        Fri Dec 23 17:03:41 2011 +0800
summary:
  Minor code style improvements in http.server suggested in Issue13294.

files:
  Lib/http/server.py |  9 +++------
  1 files changed, 3 insertions(+), 6 deletions(-)


diff --git a/Lib/http/server.py b/Lib/http/server.py
--- a/Lib/http/server.py
+++ b/Lib/http/server.py
@@ -271,14 +271,11 @@
         self.request_version = version = self.default_request_version
         self.close_connection = 1
         requestline = str(self.raw_requestline, 'iso-8859-1')
-        if requestline[-2:] == '\r\n':
-            requestline = requestline[:-2]
-        elif requestline[-1:] == '\n':
-            requestline = requestline[:-1]
+        requestline = requestline.rstrip('\r\n')
         self.requestline = requestline
         words = requestline.split()
         if len(words) == 3:
-            [command, path, version] = words
+            command, path, version = words
             if version[:5] != 'HTTP/':
                 self.send_error(400, "Bad request version (%r)" % version)
                 return False
@@ -304,7 +301,7 @@
                           "Invalid HTTP Version (%s)" % base_version_number)
                 return False
         elif len(words) == 2:
-            [command, path] = words
+            command, path = words
             self.close_connection = 1
             if command != 'GET':
                 self.send_error(400,

-- 
Repository URL: http://hg.python.org/cpython


More information about the Python-checkins mailing list