[Python-checkins] cpython: Limit test scope to those platforms that can save the target filenames.

jason.coombs python-checkins at python.org
Wed Dec 28 16:45:53 CET 2011


http://hg.python.org/cpython/rev/a7744f778646
changeset:   74190:a7744f778646
user:        Jason R. Coombs <jaraco at jaraco.com>
date:        Wed Dec 28 10:45:08 2011 -0500
summary:
  Limit test scope to those platforms that can save the target filenames. Reference #11638.

files:
  Lib/distutils/tests/test_archive_util.py |  17 ++++++++++++
  1 files changed, 17 insertions(+), 0 deletions(-)


diff --git a/Lib/distutils/tests/test_archive_util.py b/Lib/distutils/tests/test_archive_util.py
--- a/Lib/distutils/tests/test_archive_util.py
+++ b/Lib/distutils/tests/test_archive_util.py
@@ -2,6 +2,7 @@
 """Tests for distutils.archive_util."""
 import unittest
 import os
+import sys
 import tarfile
 from os.path import splitdrive
 import warnings
@@ -26,6 +27,18 @@
 except ImportError:
     ZLIB_SUPPORT = False
 
+def can_fs_encode(filename):
+    """
+    Return True if the filename can be saved in the file system.
+    """
+    if os.path.supports_unicode_filenames:
+        return True
+    try:
+        filename.encode(sys.getfilesystemencoding())
+    except UnicodeEncodeError:
+        return False
+    return True
+
 
 class ArchiveUtilTestCase(support.TempdirManager,
                           support.LoggingSilencer,
@@ -36,6 +49,8 @@
         self._make_tarball('archive')
 
     @unittest.skipUnless(ZLIB_SUPPORT, 'Need zlib support to run')
+    @unittest.skipUnless(can_fs_encode('årchiv'),
+        'File system cannot handle this filename')
     def test_make_tarball_latin1(self):
         """
         Mirror test_make_tarball, except filename contains latin characters.
@@ -43,6 +58,8 @@
         self._make_tarball('årchiv') # note this isn't a real word
 
     @unittest.skipUnless(ZLIB_SUPPORT, 'Need zlib support to run')
+    @unittest.skipUnless(can_fs_encode('のアーカイブ'),
+        'File system cannot handle this filename')
     def test_make_tarball_extended(self):
         """
         Mirror test_make_tarball, except filename contains extended

-- 
Repository URL: http://hg.python.org/cpython


More information about the Python-checkins mailing list