[Python-checkins] devguide: Add cross-reference. Remove confusing statement about already failing tests
antoine.pitrou
python-checkins at python.org
Tue Jan 18 21:46:06 CET 2011
antoine.pitrou pushed d6f2ac69e011 to devguide:
http://hg.python.org/devguide/rev/d6f2ac69e011
changeset: 127:d6f2ac69e011
tag: tip
user: Antoine Pitrou <solipsis at pitrou.net>
date: Tue Jan 18 21:46:03 2011 +0100
summary:
Add cross-reference. Remove confusing statement about already failing tests
(we don't have failing tests!). Explain why the whole test suite should be
run.
files:
patch.rst
diff --git a/patch.rst b/patch.rst
--- a/patch.rst
+++ b/patch.rst
@@ -52,9 +52,10 @@
''''''''''
Before creating your patch, you should make sure that the entire test suite
-runs without failure because of your changes. The only time a patch will be
-accepted with failing tests is because the tests fail without the patch applied
-and and the patch does not make the pre-existing failures worse.
+:ref:`runs <runtests>` without failure because of your changes. It is not
+sufficient to only run whichever test seems impacted by your changes, because
+there might be interferences unknown to you between your changes and some
+other part of the interpreter.
To perform a quick sanity check on your patch, you can run::
--
Repository URL: http://hg.python.org/devguide
More information about the Python-checkins
mailing list