[Python-checkins] cpython (merge 3.2 -> default): (merge 3.2) Issue #12363: increase the timeout of siginterrupt() tests

victor.stinner python-checkins at python.org
Fri Jul 1 16:00:00 CEST 2011


http://hg.python.org/cpython/rev/423268537083
changeset:   71118:423268537083
parent:      71116:7feb11a8acc4
parent:      71117:3f30cfe51315
user:        Victor Stinner <victor.stinner at haypocalc.com>
date:        Fri Jul 01 15:59:54 2011 +0200
summary:
  (merge 3.2) Issue #12363: increase the timeout of siginterrupt() tests

Move also the "ready" trigger after the installation of the signal handler and
the call to siginterrupt().

Use a timeout of 5 seconds instead of 3. Two seconds are supposed to be enough,
but some of our buildbots are really slow (especially the FreeBSD 6 VM).

files:
  Lib/test/test_signal.py |  8 ++++----
  1 files changed, 4 insertions(+), 4 deletions(-)


diff --git a/Lib/test/test_signal.py b/Lib/test/test_signal.py
--- a/Lib/test/test_signal.py
+++ b/Lib/test/test_signal.py
@@ -358,13 +358,13 @@
             def handler(signum, frame):
                 pass
 
-            print("ready")
-            sys.stdout.flush()
-
             signal.signal(signal.SIGALRM, handler)
             if interrupt is not None:
                 signal.siginterrupt(signal.SIGALRM, interrupt)
 
+            print("ready")
+            sys.stdout.flush()
+
             # run the test twice
             for loop in range(2):
                 # send a SIGALRM in a second (during the read)
@@ -384,7 +384,7 @@
                 # wait until the child process is loaded and has started
                 first_line = process.stdout.readline()
 
-                stdout, stderr = process.communicate(timeout=3.0)
+                stdout, stderr = process.communicate(timeout=5.0)
             except subprocess.TimeoutExpired:
                 process.kill()
                 return False

-- 
Repository URL: http://hg.python.org/cpython


More information about the Python-checkins mailing list