[Python-checkins] cpython: Fix #11512. Add an initial test suite for the cgitb, providing 75% coverage.
brian.curtin
python-checkins at python.org
Wed Jul 6 02:16:53 CEST 2011
http://hg.python.org/cpython/rev/7e0102ec95d4
changeset: 71238:7e0102ec95d4
parent: 71236:0e5485634817
user: Brian Curtin <brian at python.org>
date: Tue Jul 05 19:14:16 2011 -0500
summary:
Fix #11512. Add an initial test suite for the cgitb, providing 75% coverage.
Patch by Robbie Clemons (robquad), produced at the PyCon 2011 sprints.
files:
Lib/test/test_cgitb.py | 55 ++++++++++++++++++++++++++++++
Misc/ACKS | 1 +
Misc/NEWS | 2 +
3 files changed, 58 insertions(+), 0 deletions(-)
diff --git a/Lib/test/test_cgitb.py b/Lib/test/test_cgitb.py
new file mode 100644
--- /dev/null
+++ b/Lib/test/test_cgitb.py
@@ -0,0 +1,55 @@
+from test.support import run_unittest
+import unittest
+import sys
+import subprocess
+import cgitb
+
+class TestCgitb(unittest.TestCase):
+
+ def test_fonts(self):
+ text = "Hello Robbie!"
+ self.assertEqual(cgitb.small(text), "<small>{}</small>".format(text))
+ self.assertEqual(cgitb.strong(text), "<strong>{}</strong>".format(text))
+ self.assertEqual(cgitb.grey(text),
+ '<font color="#909090">{}</font>'.format(text))
+
+ def test_blanks(self):
+ self.assertEqual(cgitb.small(""), "")
+ self.assertEqual(cgitb.strong(""), "")
+ self.assertEqual(cgitb.grey(""), "")
+
+ def test_html(self):
+ try:
+ raise ValueError("Hello World")
+ except ValueError as err:
+ # If the html was templated we could do a bit more here.
+ # At least check that we get details on what we just raised.
+ html = cgitb.html(sys.exc_info())
+ self.assertIn("ValueError", html)
+ self.assertIn(str(err), html)
+
+ def test_text(self):
+ try:
+ raise ValueError("Hello World")
+ except ValueError as err:
+ text = cgitb.text(sys.exc_info())
+ self.assertIn("ValueError", text)
+ self.assertIn("Hello World", text)
+
+ def test_hook(self):
+ proc = subprocess.Popen([sys.executable, '-c',
+ ('import cgitb;'
+ 'cgitb.enable();'
+ 'raise ValueError("Hello World")')],
+ stdout=subprocess.PIPE)
+ out = proc.stdout.read().decode(sys.getfilesystemencoding())
+ self.addCleanup(proc.stdout.close)
+ self.assertIn("ValueError", out)
+ self.assertIn("Hello World", out)
+
+
+def test_main():
+ run_unittest(TestCgitb)
+
+if __name__ == "__main__":
+ test_main()
diff --git a/Misc/ACKS b/Misc/ACKS
--- a/Misc/ACKS
+++ b/Misc/ACKS
@@ -175,6 +175,7 @@
Mike Clarkson
Andrew Clegg
Brad Clements
+Robbie Clemons
Steve Clift
Nick Coghlan
Josh Cogliati
diff --git a/Misc/NEWS b/Misc/NEWS
--- a/Misc/NEWS
+++ b/Misc/NEWS
@@ -994,6 +994,8 @@
Tests
-----
+- Issue #11512: Add a test suite for the cgitb module. Patch by Robbie Clemons.
+
- Issue #12497: Install test/data to prevent failures of the various codecmaps
tests.
--
Repository URL: http://hg.python.org/cpython
More information about the Python-checkins
mailing list