[Python-checkins] cpython (3.2): Issue 12404: Remove C89 incompatible code from mmap module.

ross.lagerwall python-checkins at python.org
Sat Jun 25 10:14:18 CEST 2011


http://hg.python.org/cpython/rev/567236a7122c
changeset:   70945:567236a7122c
branch:      3.2
parent:      70941:2a4764376c51
user:        Ross Lagerwall <rosslagerwall at gmail.com>
date:        Sat Jun 25 10:02:37 2011 +0200
summary:
  Issue 12404: Remove C89 incompatible code from mmap module.

Patch by Akira Kitada.

files:
  Misc/NEWS            |  3 +++
  Modules/mmapmodule.c |  3 ++-
  2 files changed, 5 insertions(+), 1 deletions(-)


diff --git a/Misc/NEWS b/Misc/NEWS
--- a/Misc/NEWS
+++ b/Misc/NEWS
@@ -25,6 +25,9 @@
 Library
 -------
 
+- Issue #12404: Remove C89 incompatible code from mmap module. Patch by Akira
+  Kitada.
+
 - Issue #12383: Fix subprocess module with env={}: don't copy the environment
   variables, start with an empty environment.
 
diff --git a/Modules/mmapmodule.c b/Modules/mmapmodule.c
--- a/Modules/mmapmodule.c
+++ b/Modules/mmapmodule.c
@@ -1140,12 +1140,13 @@
 #  endif
     if (fd != -1 && fstat(fd, &st) == 0 && S_ISREG(st.st_mode)) {
         if (map_size == 0) {
+            off_t calc_size;
             if (offset >= st.st_size) {
                 PyErr_SetString(PyExc_ValueError,
                                 "mmap offset is greater than file size");
                 return NULL;
             }
-            off_t calc_size = st.st_size - offset;
+            calc_size = st.st_size - offset;
             map_size = calc_size;
             if (map_size != calc_size) {
                 PyErr_SetString(PyExc_ValueError,

-- 
Repository URL: http://hg.python.org/cpython


More information about the Python-checkins mailing list