[Python-checkins] devguide: More miscellaneous review comments.

ned.deily python-checkins at python.org
Sun Mar 6 06:00:11 CET 2011


http://hg.python.org/devguide/rev/3a213a6a7dc9
changeset:   371:3a213a6a7dc9
user:        Ned Deily <nad at acm.org>
date:        Sat Mar 05 20:57:35 2011 -0800
summary:
  More miscellaneous review comments.

files:
  experts.rst
  fixingissues.rst
  helptriage.rst

diff --git a/experts.rst b/experts.rst
--- a/experts.rst
+++ b/experts.rst
@@ -273,7 +273,7 @@
 FreeBSD
 HP-UX
 Linux
-Mac                 ronaldoussoren, ned.deily
+Mac OS X            ronaldoussoren, ned.deily
 NetBSD1
 OS2/EMX             aimacintyre
 Solaris
diff --git a/fixingissues.rst b/fixingissues.rst
--- a/fixingissues.rst
+++ b/fixingissues.rst
@@ -21,3 +21,5 @@
 or not.
 
 .. _"easy" issues: http://bugs.python.org/issue?status=1&@sort=-activity&@dispname=Easy%20issues&@startwith=0&@filter=&@group=priority&@columns=id,activity,title,creator,status&keywords=6&@action=search&@pagesize=50
+
+.. TODO: add something about no active core developer for the area?
diff --git a/helptriage.rst b/helptriage.rst
--- a/helptriage.rst
+++ b/helptriage.rst
@@ -6,9 +6,10 @@
 Once you know your way around how Python's source files are
 structured and you are comfortable working with patches, a great way to
 participate is to help triage issues. Do realize, though, that experience
-working on Python is needed in order to affectively help triage.
+working on Python is needed in order to effectively help triage.
 
-On a daily basis, issues get reported on the `issue tracker`_. Each and every
+Around the clock, new issues are being opened on the `issue tracker`_ and
+existing issues are being updated. Every
 issue needs to be triaged to make sure various things are in proper order. Even
 without special privileges you can help with this process.
 
@@ -18,9 +19,9 @@
 
 For bugs, an issue needs to:
 
-* Clearly explain the bug so it can be reproduced
-* All relevant platform details are included
-* What version(s) of Python are affected by the bug are fully known
+* clearly explain the bug so it can be reproduced
+* include all relevant platform details
+* state what version(s) of Python are affected by the bug.
 
 These are things you can help with once you have experience developing for
 Python. For instance, if a bug is not clearly explained enough for you to
@@ -42,12 +43,12 @@
 If an issue has a patch attached that has not been reviewed, you can help by
 making sure the patch:
 
-* Follows the style guides
-* Applies cleanly to an up-to-date checkout
-* Is a good solution to the problem it is trying to solve
-* There are proper tests
-* The proper documentation changes are included
-* The person is listed in ``Misc/ACKS``, either already or the patches add them
+* follows the style guides
+* applies cleanly to an up-to-date checkout
+* is a good solution to the problem it is trying to solve
+* includes proper tests
+* includes proper documentation changes
+* submitter is listed in ``Misc/ACKS``, either already or the patch adds them
 
 Doing all of this allows core developers and :ref:`triagers <devrole>` to more
 quickly look for subtle issues that only people with extensive experience

-- 
Repository URL: http://hg.python.org/devguide


More information about the Python-checkins mailing list