[Python-checkins] cpython: Use start_new_session in the webbrowser module rather than a python os.setsid

gregory.p.smith python-checkins at python.org
Tue Mar 15 20:52:41 CET 2011


http://hg.python.org/cpython/rev/d71476b9a55d
changeset:   68521:d71476b9a55d
user:        Gregory P. Smith <greg at krypto.org>
date:        Tue Mar 15 14:58:08 2011 -0400
summary:
  Use start_new_session in the webbrowser module rather than a python os.setsid preeexec_fn.

files:
  Lib/webbrowser.py

diff --git a/Lib/webbrowser.py b/Lib/webbrowser.py
--- a/Lib/webbrowser.py
+++ b/Lib/webbrowser.py
@@ -228,15 +228,9 @@
         else:
             # for TTY browsers, we need stdin/out
             inout = None
-        # if possible, put browser in separate process group, so
-        # keyboard interrupts don't affect browser as well as Python
-        setsid = getattr(os, 'setsid', None)
-        if not setsid:
-            setsid = getattr(os, 'setpgrp', None)
-
         p = subprocess.Popen(cmdline, close_fds=True, stdin=inout,
                              stdout=(self.redirect_stdout and inout or None),
-                             stderr=inout, preexec_fn=setsid)
+                             stderr=inout, start_new_session=True)
         if remote:
             # wait five secons. If the subprocess is not finished, the
             # remote invocation has (hopefully) started a new instance.

-- 
Repository URL: http://hg.python.org/cpython


More information about the Python-checkins mailing list