[Python-checkins] cpython: Issue #11727: Antoine and Arfrever don't like "0 < timeout" style (regrtest.py)

victor.stinner python-checkins at python.org
Thu Mar 31 18:28:25 CEST 2011


http://hg.python.org/cpython/rev/0f3dbf93ac06
changeset:   69085:0f3dbf93ac06
user:        Victor Stinner <victor.stinner at haypocalc.com>
date:        Thu Mar 31 18:27:50 2011 +0200
summary:
  Issue #11727: Antoine and Arfrever don't like "0 < timeout" style (regrtest.py)

files:
  Lib/test/regrtest.py |  5 +++--
  1 files changed, 3 insertions(+), 2 deletions(-)


diff --git a/Lib/test/regrtest.py b/Lib/test/regrtest.py
--- a/Lib/test/regrtest.py
+++ b/Lib/test/regrtest.py
@@ -818,7 +818,8 @@
     support.verbose = verbose  # Tell tests to be moderately quiet
     if use_resources is not None:
         support.use_resources = use_resources
-    if timeout is not None and timeout > 0:
+    use_timeout = (timeout is not None and timeout > 0)
+    if use_timeout:
         faulthandler.dump_tracebacks_later(timeout, exit=True)
     try:
         result = runtest_inner(test, verbose, quiet, huntrleaks, debug)
@@ -830,7 +831,7 @@
             runtest(test, True, quiet, huntrleaks, debug, timeout=timeout)
         return result
     finally:
-        if timeout and 0 < timeout:
+        if use_timeout:
             faulthandler.cancel_dump_tracebacks_later()
         cleanup_test_droppings(test, verbose)
 

-- 
Repository URL: http://hg.python.org/cpython


More information about the Python-checkins mailing list