[Python-checkins] cpython (2.7): Issue #12175: RawIOBase.readall() now returns None if read() returns None.
victor.stinner
python-checkins at python.org
Wed May 25 22:53:59 CEST 2011
http://hg.python.org/cpython/rev/43a498da8680
changeset: 70388:43a498da8680
branch: 2.7
parent: 70384:f2414bb35c96
user: Victor Stinner <victor.stinner at haypocalc.com>
date: Wed May 25 22:52:37 2011 +0200
summary:
Issue #12175: RawIOBase.readall() now returns None if read() returns None.
files:
Lib/_pyio.py | 6 +++++-
Lib/test/test_io.py | 7 +++++--
Misc/NEWS | 2 ++
Modules/_io/iobase.c | 8 ++++++++
4 files changed, 20 insertions(+), 3 deletions(-)
diff --git a/Lib/_pyio.py b/Lib/_pyio.py
--- a/Lib/_pyio.py
+++ b/Lib/_pyio.py
@@ -560,7 +560,11 @@
if not data:
break
res += data
- return bytes(res)
+ if res:
+ return bytes(res)
+ else:
+ # b'' or None
+ return data
def readinto(self, b):
"""Read up to len(b) bytes into b.
diff --git a/Lib/test/test_io.py b/Lib/test/test_io.py
--- a/Lib/test/test_io.py
+++ b/Lib/test/test_io.py
@@ -798,14 +798,17 @@
# Inject some None's in there to simulate EWOULDBLOCK
rawio = self.MockRawIO((b"abc", b"d", None, b"efg", None, None, None))
bufio = self.tp(rawio)
-
self.assertEqual(b"abcd", bufio.read(6))
self.assertEqual(b"e", bufio.read(1))
self.assertEqual(b"fg", bufio.read())
self.assertEqual(b"", bufio.peek(1))
- self.assertTrue(None is bufio.read())
+ self.assertIsNone(bufio.read())
self.assertEqual(b"", bufio.read())
+ rawio = self.MockRawIO((b"a", None, None))
+ self.assertEqual(b"a", rawio.readall())
+ self.assertIsNone(rawio.readall())
+
def test_read_past_eof(self):
rawio = self.MockRawIO((b"abc", b"d", b"efg"))
bufio = self.tp(rawio)
diff --git a/Misc/NEWS b/Misc/NEWS
--- a/Misc/NEWS
+++ b/Misc/NEWS
@@ -83,6 +83,8 @@
Library
-------
+- Issue #12175: RawIOBase.readall() now returns None if read() returns None.
+
- Issue #12175: FileIO.readall() now raises a ValueError instead of an IOError
if the file is closed.
diff --git a/Modules/_io/iobase.c b/Modules/_io/iobase.c
--- a/Modules/_io/iobase.c
+++ b/Modules/_io/iobase.c
@@ -814,6 +814,14 @@
Py_DECREF(chunks);
return NULL;
}
+ if (data == Py_None) {
+ if (PyList_GET_SIZE(chunks) == 0) {
+ Py_DECREF(chunks);
+ return data;
+ }
+ Py_DECREF(data);
+ break;
+ }
if (!PyBytes_Check(data)) {
Py_DECREF(chunks);
Py_DECREF(data);
--
Repository URL: http://hg.python.org/cpython
More information about the Python-checkins
mailing list