[Python-checkins] cpython (3.2): Closes #13140: Fix the daemon_threads attribute of ThreadingMixIn.
florent.xicluna
python-checkins at python.org
Fri Nov 4 10:23:29 CET 2011
http://hg.python.org/cpython/rev/94017ce9304d
changeset: 73348:94017ce9304d
branch: 3.2
parent: 73342:fa9c69dcf31b
user: Florent Xicluna <florent.xicluna at gmail.com>
date: Fri Nov 04 10:16:28 2011 +0100
summary:
Closes #13140: Fix the daemon_threads attribute of ThreadingMixIn.
files:
Lib/socketserver.py | 3 +--
Lib/test/test_socketserver.py | 1 -
Misc/NEWS | 2 ++
3 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/Lib/socketserver.py b/Lib/socketserver.py
--- a/Lib/socketserver.py
+++ b/Lib/socketserver.py
@@ -588,8 +588,7 @@
"""Start a new thread to process the request."""
t = threading.Thread(target = self.process_request_thread,
args = (request, client_address))
- if self.daemon_threads:
- t.daemon = True
+ t.daemon = self.daemon_threads
t.start()
diff --git a/Lib/test/test_socketserver.py b/Lib/test/test_socketserver.py
--- a/Lib/test/test_socketserver.py
+++ b/Lib/test/test_socketserver.py
@@ -123,7 +123,6 @@
self.assertEqual(server.server_address, server.socket.getsockname())
return server
- @unittest.skipUnless(threading, 'Threading required for this test.')
@reap_threads
def run_server(self, svrcls, hdlrbase, testfunc):
server = self.make_server(self.pickaddr(svrcls.address_family),
diff --git a/Misc/NEWS b/Misc/NEWS
--- a/Misc/NEWS
+++ b/Misc/NEWS
@@ -66,6 +66,8 @@
Library
-------
+- Issue #13140: Fix the daemon_threads attribute of ThreadingMixIn.
+
- Issue #13339: Fix compile error in posixmodule.c due to missing semicolon.
Thanks to Robert Xiao.
--
Repository URL: http://hg.python.org/cpython
More information about the Python-checkins
mailing list