[Python-checkins] [Python-Dev] cpython (3.2): adjust braces a bit
Eric V. Smith
eric at trueblade.com
Fri Oct 21 20:31:48 CEST 2011
On 10/21/2011 12:31 PM, Benjamin Peterson wrote:
> 2011/10/21 Eric V. Smith <eric at trueblade.com>:
>> What's the logic for adding some braces, but removing others?
>
> No braces if everything is a one-liner, otherwise braces everywhere.
Not sure what "everything" means here. My specific question is why
braces were added here:
- if (tb == Py_None)
+ if (tb == Py_None) {
tb = NULL;
+ }
And removed here:
- if (PyExceptionClass_Check(typ)) {
+ if (PyExceptionClass_Check(typ))
PyErr_NormalizeException(&typ, &val, &tb);
- }
I don't have any particular preference, but consistency seems important.
More information about the Python-checkins
mailing list