[Python-checkins] cpython: Fix clock_gettime/getres/settime: PyArg_ParseTuple() expects an int

[victor.stinner]

http://hg.python.org/cpython/rev/06c4792143ab
changeset:   76290:06c4792143ab
user:        Victor Stinner <victor.stinner at gmail.com>
date:        Fri Apr 13 23:44:05 2012 +0200
summary:
  Fix clock_gettime/getres/settime: PyArg_ParseTuple() expects an int

Only use a single #ifdef for the 3 functions.

files:
  Modules/timemodule.c |  14 ++++----------
  1 files changed, 4 insertions(+), 10 deletions(-)


diff --git a/Modules/timemodule.c b/Modules/timemodule.c
--- a/Modules/timemodule.c
+++ b/Modules/timemodule.c
@@ -139,7 +139,7 @@
 time_clock_gettime(PyObject *self, PyObject *args)
 {
     int ret;
-    clockid_t clk_id;
+    int clk_id;
     struct timespec tp;
 
     if (!PyArg_ParseTuple(args, "i:clock_gettime", &clk_id))
@@ -162,7 +162,7 @@
 static PyObject *
 time_clock_settime(PyObject *self, PyObject *args)
 {
-    clockid_t clk_id;
+    int clk_id;
     PyObject *obj;
     struct timespec tp;
     int ret;
@@ -185,14 +185,12 @@
 "clock_settime(clk_id, time)\n\
 \n\
 Set the time of the specified clock clk_id.");
-#endif
 
-#ifdef HAVE_CLOCK_GETRES
 static PyObject *
 time_clock_getres(PyObject *self, PyObject *args)
 {
     int ret;
-    clockid_t clk_id;
+    int clk_id;
     struct timespec tp;
 
     if (!PyArg_ParseTuple(args, "i:clock_getres", &clk_id))
@@ -211,7 +209,7 @@
 "clock_getres(clk_id) -> floating point number\n\
 \n\
 Return the resolution (precision) of the specified clock clk_id.");
-#endif
+#endif   /* HAVE_CLOCK_GETTIME */
 
 static PyObject *
 time_sleep(PyObject *self, PyObject *args)
@@ -1009,11 +1007,7 @@
 #endif
 #ifdef HAVE_CLOCK_GETTIME
     {"clock_gettime",   time_clock_gettime, METH_VARARGS, clock_gettime_doc},
-#endif
-#ifdef HAVE_CLOCK_GETTIME
     {"clock_settime",   time_clock_settime, METH_VARARGS, clock_settime_doc},
-#endif
-#ifdef HAVE_CLOCK_GETRES
     {"clock_getres",    time_clock_getres, METH_VARARGS, clock_getres_doc},
 #endif
     {"sleep",           time_sleep, METH_VARARGS, sleep_doc},

-- 
Repository URL: http://hg.python.org/cpython