[Python-checkins] cpython: Fix a refleak

antoine.pitrou python-checkins at python.org
Mon Apr 16 21:54:47 CEST 2012


http://hg.python.org/cpython/rev/a3e9d5c239c4
changeset:   76361:a3e9d5c239c4
user:        Antoine Pitrou <solipsis at pitrou.net>
date:        Mon Apr 16 21:52:45 2012 +0200
summary:
  Fix a refleak

files:
  Python/import.c |  5 +++--
  1 files changed, 3 insertions(+), 2 deletions(-)


diff --git a/Python/import.c b/Python/import.c
--- a/Python/import.c
+++ b/Python/import.c
@@ -2782,10 +2782,11 @@
         }
         base = PyUnicode_Substring(package, 0, last_dot);
         if (PyUnicode_GET_LENGTH(name) > 0) {
-            PyObject *borrowed_dot = NULL;
-            PyObject *seq = PyTuple_Pack(2, base, name);
+            PyObject *borrowed_dot, *seq = NULL;
 
             borrowed_dot = _PyUnicode_FromId(&single_dot);
+            seq = PyTuple_Pack(2, base, name);
+            Py_DECREF(base);
             if (borrowed_dot == NULL || seq == NULL) {
                 goto error;
             }

-- 
Repository URL: http://hg.python.org/cpython


More information about the Python-checkins mailing list