[Python-checkins] cpython (3.2): Issue #5113: Fix a test_posix failure on HP-UX, where non-root users can

charles-francois.natali python-checkins at python.org
Tue Apr 17 19:59:31 CEST 2012


http://hg.python.org/cpython/rev/428bece48029
changeset:   76377:428bece48029
branch:      3.2
parent:      76366:cf880f002f3c
user:        Charles-François Natali <neologix at free.fr>
date:        Tue Apr 17 19:48:35 2012 +0200
summary:
  Issue #5113: Fix a test_posix failure on HP-UX, where non-root users can
chown() to root under certain circumstances.

files:
  Lib/test/test_posix.py |  11 +++++++++--
  1 files changed, 9 insertions(+), 2 deletions(-)


diff --git a/Lib/test/test_posix.py b/Lib/test/test_posix.py
--- a/Lib/test/test_posix.py
+++ b/Lib/test/test_posix.py
@@ -9,6 +9,7 @@
 import sys
 import time
 import os
+import platform
 import pwd
 import shutil
 import stat
@@ -229,6 +230,9 @@
 
     def _test_all_chown_common(self, chown_func, first_param):
         """Common code for chown, fchown and lchown tests."""
+        # test a successful chown call
+        chown_func(first_param, os.getuid(), os.getgid())
+
         if os.getuid() == 0:
             try:
                 # Many linux distros have a nfsnobody user as MAX_UID-2
@@ -240,12 +244,15 @@
                 chown_func(first_param, ent.pw_uid, ent.pw_gid)
             except KeyError:
                 pass
+        elif platform.system() in ('HP-UX', 'SunOS'):
+            # HP-UX and Solaris can allow a non-root user to chown() to root
+            # (issue #5113)
+            raise unittest.SkipTest("Skipping because of non-standard chown() "
+                                    "behavior")
         else:
             # non-root cannot chown to root, raises OSError
             self.assertRaises(OSError, chown_func,
                               first_param, 0, 0)
-        # test a successful chown call
-        chown_func(first_param, os.getuid(), os.getgid())
 
     @unittest.skipUnless(hasattr(posix, 'chown'), "test needs os.chown()")
     def test_chown(self):

-- 
Repository URL: http://hg.python.org/cpython


More information about the Python-checkins mailing list