[Python-checkins] cpython (3.2): Issue #14574: Ignore socket errors raised when flushing a connection on close.

kristjan.jonsson python-checkins at python.org
Wed Dec 26 16:30:28 CET 2012


http://hg.python.org/cpython/rev/7e5d7ef4634d
changeset:   81066:7e5d7ef4634d
branch:      3.2
parent:      81059:0eccfb237364
user:        Kristján Valur Jónsson <kristjan at ccpgames.com>
date:        Tue Dec 25 22:46:32 2012 +0000
summary:
  Issue #14574: Ignore socket errors raised when flushing a connection on close.

files:
  Doc/library/socketserver.rst |  4 ++--
  Lib/socketserver.py          |  7 ++++++-
  2 files changed, 8 insertions(+), 3 deletions(-)


diff --git a/Doc/library/socketserver.rst b/Doc/library/socketserver.rst
--- a/Doc/library/socketserver.rst
+++ b/Doc/library/socketserver.rst
@@ -299,8 +299,8 @@
 .. method:: RequestHandler.finish()
 
    Called after the :meth:`handle` method to perform any clean-up actions
-   required.  The default implementation does nothing.  If :meth:`setup` or
-   :meth:`handle` raise an exception, this function will not be called.
+   required.  The default implementation does nothing.  If :meth:`setup`
+   raises an exception, this function will not be called.
 
 
 .. method:: RequestHandler.handle()
diff --git a/Lib/socketserver.py b/Lib/socketserver.py
--- a/Lib/socketserver.py
+++ b/Lib/socketserver.py
@@ -700,7 +700,12 @@
 
     def finish(self):
         if not self.wfile.closed:
-            self.wfile.flush()
+            try:
+                self.wfile.flush()
+            except socket.error:
+                # An final socket error may have occurred here, such as
+                # the local error ECONNABORTED.
+                pass
         self.wfile.close()
         self.rfile.close()
 

-- 
Repository URL: http://hg.python.org/cpython


More information about the Python-checkins mailing list